fix(test): unblock root pixi run test workflow#1978
Open
rparolin wants to merge 6 commits intoNVIDIA:mainfrom
Open
fix(test): unblock root pixi run test workflow#1978rparolin wants to merge 6 commits intoNVIDIA:mainfrom
rparolin wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
`pixi run test` failed at the cuda_bindings build stage because list-form pixi `cmd` arrays didn't expand `$PIXI_ENVIRONMENT_NAME` reliably, so the inner per-package `pixi run` calls picked the cuda_bindings default environment (no cuda-version pin). The conda solver then resolved cuda-version=12.9 and the build failed with a missing `CUatomicOperation_enum` (a CUDA-13.x-only symbol). Wrap the three test-* tasks in `bash -c '...'` so the shell expands `$PIXI_ENVIRONMENT_NAME` and forward it explicitly via `-e` to each inner pixi run. Once the bindings build was unblocked, cuda_core's cython test build hit a second issue: `cythonize` cannot resolve `cimport cuda.bindings.*` against pixi-build's editable install, which exposes the cuda namespace package via a finder hook that Cython's filesystem .pxd resolver does not consult. Replace the `cythonize` CLI invocation with a small Python wrapper that calls `Cython.Build.cythonize()` with an explicit `include_path` resolved from the imported `cuda.bindings` package. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rparolin
added
bug
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop cuda_core/tests/cython/build_tests.py in favor of a small PYTHONPATH shim in build_tests.sh. Same outcome (Cython's .pxd resolver finds cuda.bindings via the package's parent directory), three lines instead of a separate setuptools entry point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Replace the PYTHONPATH shim in cuda_core/tests/cython/build_tests.sh
with a small Python driver (build_tests.py) that calls
Cython.Build.cythonize() with an explicit include_path resolved at
runtime from cuda.bindings.__file__. Avoids platform-specific
PYTHONPATH separator handling and surfaces missing-import failures
as Python exceptions instead of silent fallbacks.
Apply the same wrapper pattern to cuda_bindings/tests/cython/ for
symmetry; both shell scripts gain `set -eo pipefail` and `${VAR:-}`
defaults so the previously optional CPLUS_INCLUDE_PATH / CL env vars
keep working under stricter error mode.
Expand the pixi.toml comment block to document why each test-* task
is wrapped in `bash -c '...'` and note Linux-only scope.
Verified end-to-end: `pixi run test` passes 4,314 tests
(974 pathfinder + 384 bindings + 2,956 core), 208 skipped, 2 xfailed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
cuda.bindings
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
Code reviewNo issues found. Checked for bugs and AGENTS.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
rparolin
removed
cuda.bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pixi run testwas failing end-to-end. Two stacked root causes:List-form pixi
cmdarrays didn't expand$PIXI_ENVIRONMENT_NAME. The roottest-*tasks dropped into each sub-package without forwarding the active environment, so the innerpixi runpicked the sub-package'sdefaultenvironment. Incuda_bindings/pixi.tomlandcuda_core/pixi.toml,defaulthas nocuda-versionpin — the conda solver resolved a CUDA-12.x toolkit, and the build failed compiling Cython output that referencesCUatomicOperation_enum(a CUDA-13.x-only symbol). Fix: wrap eachtest-*task inbash -c '…'so the shell expands$PIXI_ENVIRONMENT_NAMEand forwards it explicitly via-eto the innerpixi run.Cython couldn't find cross-package
.pxdfiles under pixi-build's editable install. pixi-build installscuda-bindingsvia a PEP 660 finder hook; runtime imports honor it but Cython's filesystem.pxdresolver does not. Fix: replace thecythonizeCLI invocation in bothcuda_core/tests/cython/build_tests.shandcuda_bindings/tests/cython/build_tests.shwith a small Python wrapper (build_tests.py) that callsCython.Build.cythonize()with an explicitinclude_pathresolved at runtime fromcuda.bindings.__file__. This avoids platform-specificPYTHONPATHseparator handling and surfaces missing-import failures as Python exceptions instead of silent fallbacks.Files changed
pixi.toml— threetest-*tasks switched tobash -c '…'form forwarding-e "$PIXI_ENVIRONMENT_NAME"; comment block expanded with rationale and Linux-only scope note.cuda_core/tests/cython/build_tests.sh— addsset -euo pipefail; invokes newbuild_tests.pyinstead of thecythonizeCLI; still ownsCPLUS_INCLUDE_PATH/CLsetup.cuda_core/tests/cython/build_tests.py— new; resolves the cuda namespace package's parent dir at runtime and runscythonize() + setup(... build_ext --inplace)with an explicitinclude_path.cuda_bindings/tests/cython/build_tests.sh— addsset -euo pipefail; switches to the new wrapper; preservesCPLUS_INCLUDE_PATH/CLsetup.cuda_bindings/tests/cython/build_tests.py— new; mirror of the cuda_core wrapper, withnthreads=1to preserve the previous-j 1deterministic-build behavior.🤖 Generated with Claude Code